Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add -c shorthand for --container-runtime #19217

Merged
merged 1 commit into from
Jul 10, 2024
Merged

add -c shorthand for --container-runtime #19217

merged 1 commit into from
Jul 10, 2024

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Jul 9, 2024 •
edited
Loading

making it easier to type container-runtime

after this PR

$ mk start -c containerd
😄  minikube v1.33.1 on Darwin 14.5 (arm64)
✨  Automatically selected the docker driver. Other choices: qemu2, ssh
📌  Using Docker Desktop driver with root privileges
👍  Starting "minikube" primary control-plane node in "minikube" cluster
🚜  Pulling base image v0.0.44-1720012048-19186 ...
💾  Downloading Kubernetes v1.30.2 preload ...
    > preloaded-images-k8s-v18-v1...:  350.31 MiB / 350.31 MiB  100.00% 30.03 M
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
📦  Preparing Kubernetes v1.30.2 on containerd 1.7.18 ...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 9, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2024
@medyagh
Copy link
Member Author

medyagh commented Jul 9, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 9, 2024
@medyagh
Copy link
Member Author

medyagh commented Jul 9, 2024

/ok-to-test

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19217) |
+----------------+----------+---------------------+
| minikube start | 48.2s    | 49.9s               |
| enable ingress | 26.4s    | 24.6s               |
+----------------+----------+---------------------+

Times for minikube start: 49.7s 46.6s 50.7s 47.0s 47.0s
Times for minikube (PR 19217) start: 51.4s 50.3s 51.0s 47.8s 49.1s

Times for minikube ingress: 23.6s 28.5s 27.9s 26.9s 24.9s
Times for minikube (PR 19217) ingress: 23.9s 23.9s 23.9s 27.0s 24.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19217) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.3s               |
| enable ingress | 22.4s    | 21.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 21.7s 21.8s 20.8s 25.8s 21.7s
Times for minikube (PR 19217) ingress: 21.7s 21.3s 21.8s 21.8s 22.8s

Times for minikube start: 23.9s 20.7s 20.8s 20.9s 24.1s
Times for minikube (PR 19217) start: 20.7s 21.1s 20.7s 23.3s 20.7s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19217) |
+----------------+----------+---------------------+
| minikube start | 20.8s    | 21.4s               |
| enable ingress | 45.0s    | 33.0s               |
+----------------+----------+---------------------+

Times for minikube start: 19.9s 20.7s 20.1s 23.2s 20.2s
Times for minikube (PR 19217) start: 21.1s 22.9s 19.5s 23.5s 19.9s

Times for minikube ingress: 81.3s 32.3s 47.8s 31.8s 31.8s
Times for minikube (PR 19217) ingress: 48.2s 32.3s 30.7s 21.3s 32.3s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit f216598 into kubernetes:master Jul 10, 2024
25 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@medyagh @minikube-pr-bot @k8s-ci-robot @spowelljr